alamb opened a new pull request, #14038: URL: https://github.com/apache/datafusion/pull/14038
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Part of https://github.com/apache/datafusion/issues/13748 ## Rationale for this change While working to encapsulate the sort order code more, I noticed the free function `collapse_lex_ordering` that consumed a `LexOrdering` but wasn't easy to find. It also clones expressions unecessairly. ## What changes are included in this PR? 1. Move code to `LexOrdering::collapse` 2. Improve docs 3. Avoid clone ## Are these changes tested? By exisitng CI <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 4. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? No. Despite the function being `pub` it is in a non pub module, so is not exposed. You can see that it is not present in the docs: https://docs.rs/datafusion/latest/datafusion/index.html?search=collapse_lex_ordering -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
