goldmedal commented on PR #14031: URL: https://github.com/apache/datafusion/pull/14031#issuecomment-2575129897
Thanks for working on this, @MohamedAbdeen21 Instead of applying optimization rules when roundtrip tests, I prefer to construct the expected plan manually. Just like other test cases like https://github.com/apache/datafusion/blob/482b48926a871bf2c39d6808ca217e309c705b03/datafusion/sql/tests/cases/plan_to_sql.rs#L1221 If we add the optimization to the testing, the optimizer's behavior will be limited by the unparser but we don't expect it. (see the previous discussion https://github.com/apache/datafusion/pull/13267#issuecomment-2482503581) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
