jonahgao commented on issue #13994: URL: https://github.com/apache/datafusion/issues/13994#issuecomment-2574559414
> Unless there is an important reason to keep a non-mutable `&self` in the `supports_filters_pushdown` I would recommend change it to `&mut self`. This should be OK as you can only modify the custom data source struct which the implementor owns This change is not easy, especially in an async environment. We used `Arc` to store TableProvider, which naturally prohibits mutable references. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
