kazuyukitanimura commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1904652478
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -272,18 +272,19 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)
- val COMET_EXEC_SHUFFLE_COMPRESSION_CODEC: ConfigEntry[String] = conf(
- s"$COMET_EXEC_CONFIG_PREFIX.shuffle.compression.codec")
- .doc(
- "The codec of Comet native shuffle used to compress shuffle data. Only
zstd is supported. " +
- "Compression can be disabled by setting spark.shuffle.compress=false.")
- .stringConf
- .checkValues(Set("zstd"))
- .createWithDefault("zstd")
+ val COMET_EXEC_SHUFFLE_COMPRESSION_CODEC: ConfigEntry[String] =
+ conf(s"$COMET_EXEC_CONFIG_PREFIX.shuffle.compression.codec")
+ .doc(
+ "The codec of Comet native shuffle used to compress shuffle data. lz4,
zstd, and " +
+ "snappy are supported. Compression can be disabled by setting " +
+ "spark.shuffle.compress=false.")
+ .stringConf
+ .checkValues(Set("zstd", "lz4", "snappy"))
+ .createWithDefault("lz4")
val COMET_EXEC_SHUFFLE_COMPRESSION_LEVEL: ConfigEntry[Int] =
Review Comment:
nit since the config name now has `zstd`, the constant name should ideally
reflect it, but optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
