zhuqi-lucas commented on PR #13933:
URL: https://github.com/apache/datafusion/pull/13933#issuecomment-2565203405
Thank you @berkaysynnada for review and good suggestions.
I agree with you, this is not a perfect way, i will try to do following
improvement for this PR:
1. Try to make the maintaining order information unified to equivalences.
2. About the sorting_columns(), it's a row group level info, not file level
FileMetaData. I am not sure if it's a better way.
``` rust
/// Sort order within a RowGroup of a leaf column
#[derive(Clone, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub struct SortingColumn {
/// The ordinal position of the column (in this row group) *
pub column_idx: i32,
/// If true, indicates this column is sorted in descending order. *
pub descending: bool,
/// If true, nulls will come before non-null values, otherwise,
/// nulls go at the end.
pub nulls_first: bool,
}
```
3. Try to make the TableParquetOptions has the only sort_by order info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
