viirya commented on code in PR #1154:
URL: https://github.com/apache/datafusion-comet/pull/1154#discussion_r1898976737
##########
native/spark-expr/src/strings.rs:
##########
@@ -141,18 +137,43 @@ make_predicate_function!(EndsWith, ends_with_dyn,
ends_with_utf8_scalar_dyn);
make_predicate_function!(Contains, contains_dyn, contains_utf8_scalar_dyn);
-#[derive(Debug, Hash)]
+#[derive(Debug, Eq)]
pub struct SubstringExpr {
pub child: Arc<dyn PhysicalExpr>,
pub start: i64,
pub len: u64,
}
-#[derive(Debug, Hash)]
+impl Hash for SubstringExpr {
+ fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
+ self.child.hash(state);
+ self.start.hash(state);
+ self.len.hash(state);
+ }
+}
+
+impl PartialEq for SubstringExpr {
+ fn eq(&self, other: &Self) -> bool {
+ self.child.eq(&other.child) && self.start.eq(&other.start) &&
self.len.eq(&other.len)
+ }
+}
Review Comment:
Why we need to provide `PartialEq` implementation now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
