alamb commented on PR #1625: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1625#issuecomment-2564336230
> It does occur to me that this is not covered by CI. Maybe we should move the benchmark binary into the normal sqlparser crate (which I think would be more standard) rather than having an entirely separate crate (`sqlparser_bench`) -- that would also ensure the benchmark is covered by CI tests 🤔 - Added a CI check here: https://github.com/apache/datafusion-sqlparser-rs/pull/1627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
