alamb commented on PR #1618: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1618#issuecomment-2564333072
> Not sure I followed the intent of the comment, did it mean potentially replacing this api with something similar called advance or would that have a different behavior? > That is a good question -- yes I think I meant changing this API somehow so it doesn't end up preserving a mutable borrow to return the option. BTW I spent some time last night and I found indeed it is possible to avoid these APIs. Here is what I came up with: - https://github.com/apache/datafusion-sqlparser-rs/pull/1626# -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
