goldmedal commented on code in PR #1621:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1621#discussion_r1898894836
##########
src/parser/mod.rs:
##########
@@ -9002,29 +9021,32 @@ impl<'a> Parser<'a> {
}
/// Parse a simple one-word identifier (possibly quoted, possibly a
keyword)
- ///
- /// The `in_table_clause` parameter indicates whether the identifier is a
table in a FROM, JOIN, or
- /// similar table clause. Currently, this is used only to support unquoted
hyphenated identifiers in
- // this context on BigQuery.
- pub fn parse_identifier(&mut self, in_table_clause: bool) -> Result<Ident,
ParserError> {
+ pub fn parse_identifier(&mut self) -> Result<Ident, ParserError> {
Review Comment:
It would be a breaking change for the downstream project using this public
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
