jonahgao commented on code in PR #13902:
URL: https://github.com/apache/datafusion/pull/13902#discussion_r1897556998
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -40,19 +40,25 @@ pub fn main() -> Result<()> {
.block_on(run_tests())
}
-fn value_validator(actual: &[Vec<String>], expected: &[String]) -> bool {
- let expected = expected
- .iter()
- // Trailing whitespace from lines in SLT will typically be removed,
but do not fail if it is not
- // If particular test wants to cover trailing whitespace on a value,
- // it should project additional non-whitespace column on the right.
- .map(|s| s.trim_end().to_owned())
- .collect::<Vec<_>>();
+#[allow(clippy::ptr_arg)]
+fn normalizer(s: &String) -> String {
+ // Trailing whitespace from lines in SLT will typically be removed, but do
not fail if it is not
+ // If particular test wants to cover trailing whitespace on a value,
+ // it should project additional non-whitespace column on the right.
+ s.trim_end().to_owned()
+}
+
+fn value_validator(
+ normalizer: Normalizer,
Review Comment:
> That was not entirely true unfortunately, the normalization was hardcoded
in places.
`normalize_string` was an internal part of the default validator. Although
it was hard-coded, the outer validator can be user-defined. A user-defined
validator like the one provided by DataFusion can offer more flexibility to
meet specific row comparison needs, and might not require normalization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
