wiedld commented on code in PR #13651:
URL: https://github.com/apache/datafusion/pull/13651#discussion_r1896974791


##########
datafusion/sqllogictest/test_files/subquery.slt:
##########
@@ -433,17 +433,32 @@ logical_plan
 08)----------TableScan: t1 projection=[t1_int]
 
 #invalid_scalar_subquery
-statement error DataFusion error: check_analyzed_plan\ncaused by\nError during 
planning: Scalar subquery should only return one column, but found 2: t2.t2_id, 
t2.t2_name
+statement error
 SELECT t1_id, t1_name, t1_int, (select t2_id, t2_name FROM t2 WHERE t2.t2_id = 
t1.t1_int) FROM t1
+----
+DataFusion error: Invalid (non-executable) plan after Analyzer
+caused by
+Error during planning: Scalar subquery should only return one column, but 
found 2: t2.t2_id, t2.t2_name

Review Comment:
   This change was introduced with `cargo test --test sqllogictests -- 
--complete`, passing locally on macos -- but [fails in 
CI](https://github.com/apache/datafusion/actions/runs/12486329036/job/34846275597?pr=13651#step:4:6697).
 I'll figure out the whys later.



##########
datafusion/sqllogictest/test_files/subquery.slt:
##########
@@ -433,17 +433,32 @@ logical_plan
 08)----------TableScan: t1 projection=[t1_int]
 
 #invalid_scalar_subquery
-statement error DataFusion error: check_analyzed_plan\ncaused by\nError during 
planning: Scalar subquery should only return one column, but found 2: t2.t2_id, 
t2.t2_name
+statement error
 SELECT t1_id, t1_name, t1_int, (select t2_id, t2_name FROM t2 WHERE t2.t2_id = 
t1.t1_int) FROM t1
+----
+DataFusion error: Invalid (non-executable) plan after Analyzer
+caused by
+Error during planning: Scalar subquery should only return one column, but 
found 2: t2.t2_id, t2.t2_name

Review Comment:
   This change was introduced with `cargo test --test sqllogictests -- 
--complete`, passes locally on macos -- but [fails in 
CI](https://github.com/apache/datafusion/actions/runs/12486329036/job/34846275597?pr=13651#step:4:6697).
 I'll figure out the whys later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to