alamb commented on PR #13887: URL: https://github.com/apache/datafusion/pull/13887#issuecomment-2561452851
> LGTM but I have not tested with Comet. Thanks @alamb I have tested so locally -- specifically I checked out the code in https://github.com/apache/datafusion-comet/pull/1154 Changed it to use a local checkout with this PR: ```diff --- a/native/Cargo.toml +++ b/native/Cargo.toml @@ -39,15 +39,15 @@ arrow-buffer = { version = "53.3.0" } arrow-data = { version = "53.3.0" } arrow-schema = { version = "53.3.0" } parquet = { version = "53.3.0", default-features = false, features = ["experimental"] } -datafusion = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false, features = ["unicode_expressions", "crypto_expressions"] } -datafusion-common = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false } -datafusion-functions = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false, features = ["crypto_expressions"] } -datafusion-functions-nested = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false } -datafusion-expr = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false } -datafusion-expr-common = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false } -datafusion-execution = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false } -datafusion-physical-plan = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false } -datafusion-physical-expr = { git = "https://github.com/apache/datafusion.git";, rev = "242f45f", default-features = false } +datafusion = { path = "/Users/andrewlamb/Software/datafusion/datafusion/core", default-features = false, features = ["unicode_expressions", "crypto_expressions"] } +datafusion-common = { path = "/Users/andrewlamb/Software/datafusion/datafusion/common", default-features = false } +datafusion-functions = { path = "/Users/andrewlamb/Software/datafusion/datafusion/functions", default-features = false, features = ["crypto_expressions"] } +datafusion-functions-nested = { path = "/Users/andrewlamb/Software/datafusion/datafusion/functions-nested", default-features = false } +datafusion-expr = { path = "/Users/andrewlamb/Software/datafusion/datafusion/expr", default-features = false } +datafusion-expr-common = { path = "/Users/andrewlamb/Software/datafusion/datafusion/expr-common", default-features = false } +datafusion-execution = { path = "/Users/andrewlamb/Software/datafusion/datafusion/execution", default-features = false } +datafusion-physical-plan = { path = "/Users/andrewlamb/Software/datafusion/datafusion/core", default-features = false } +datafusion-physical-expr = { path = "/Users/andrewlamb/Software/datafusion/datafusion/physical-expr", default-features = false } datafusion-comet-spark-expr = { path = "spark-expr", version = "0.5.0" } datafusion-comet-proto = { path = "proto", version = "0.5.0" } chrono = { version = "0.4", default-features = false, features = ["clock"] } ``` and verified that this command passes: ```shell MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test -p datafusion-comet -- test_unpack_dictionary_primitive ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
