alamb commented on code in PR #13887:
URL: https://github.com/apache/datafusion/pull/13887#discussion_r1895840813
##########
datafusion/core/Cargo.toml:
##########
@@ -69,6 +69,13 @@ pyarrow = ["datafusion-common/pyarrow", "parquet"]
regex_expressions = [
"datafusion-functions/regex_expressions",
]
+recusive-protection = [
Review Comment:
This adds the `recursive-protection` feature to the `datafusion` (core)
crate which then activates the feature in the subcrates
##########
datafusion/sql/src/query.rs:
##########
@@ -62,10 +63,11 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
// The functions called from `set_expr_to_plan()` need more
than 128KB
// stack in debug builds as investigated in:
//
https://github.com/apache/datafusion/pull/13310#discussion_r1836813902
- let min_stack_size = recursive::get_minimum_stack_size();
Review Comment:
here is pretty good evidence that the feature flag is not working as
expected, as this code requires `recursive` to compile but it wasn't failing
the build -- I pulled the logic its own structure
##########
datafusion/common/Cargo.toml:
##########
@@ -36,7 +36,6 @@ name = "datafusion_common"
path = "src/lib.rs"
[features]
-default = ["recursive-protection"]
Review Comment:
having the feature enabled by default in subcrates meant I think it
basically was not possible to disable when using datafusion core crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
