alamb commented on issue #13763:
URL: https://github.com/apache/datafusion/issues/13763#issuecomment-2557982842

   I started writing some tests for this I could not find a way to make the 
error messages less confusing. 
   
   Specifically the error looks like this:
   ```
   Error during planning: example_union does not support zero arguments
   No function matches the given name and argument types 'example_union()'. 
   You might need to add explicit type casts.
   
   Candidate functions:
       example_union()
   ```
   
   The last suggestion of `example_union()` is very confusing to me as it 
implies that zero arguments are supported but in this case it is not. 
   
   I think the issue is that users can construct a `Signature::any(0)` but it 
is currently interpreted to be "invalid", but that can't be detected until 
execution time.
   
   I think this will be percived as a tricky/annoying regression for people who 
have existing udfs with `Signature::any`
   
   I also did some testing and it turns out that there are several other ways 
people could represent zero argument signatures (`TypeSignature::Uniform(0, 
..)` for example which **are** still allowed
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to