andygrove commented on issue #10315:
URL: https://github.com/apache/datafusion/issues/10315#issuecomment-2552112849
At first glance, `parse_decimal` looks more mature and more efficient than
`parse_string_to_decimal_native`.
For example, `parse_string_to_decimal_native` has some expensive operations
that are avoided in `parse_decimal`:
```rust
let value_str = value_str.trim();
let parts: Vec<&str> = value_str.split('.').collect();
```
It does seem to make sense to do what you suggest and use `parse_decimal`
and fix the bug there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
