parthchandra commented on code in PR #1177:
URL: https://github.com/apache/datafusion-comet/pull/1177#discussion_r1889389529
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -921,8 +921,8 @@ class CometSparkSessionExtensions
override def apply(plan: SparkPlan): SparkPlan = {
// Comet required off-heap memory to be enabled
- if ("true" != conf.getConfString("spark.memory.offHeap.enabled",
"false")) {
- logInfo("Comet extension disabled because
spark.memory.offHeap.enabled=false")
+ if (!isOffHeapEnabled(conf) && !isTesting) {
+ logWarning("Comet extension disabled because
spark.memory.offHeap.enabled=false")
Review Comment:
Should we add this to extended explain info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
