alamb opened a new pull request, #13749: URL: https://github.com/apache/datafusion/pull/13749
## Which issue does this PR close? - Related to https://github.com/apache/datafusion/pull/13691 ## Rationale for this change @tlm365 says: https://github.com/apache/datafusion/pull/13691#discussion_r1877208207 > @Dandandan you're right. I tested it with some unit tests for special characters (unicode), this PR's implementation doesn't work and the old implementation doesn't work either. But I think it makes sense at the moment since the initcap function is in datafusion::function::string not datafusion::function::unicode. > > Perhaps, it would be better if we update the documentation that initcap is not supported for unicode characters yet and try to handle it if necessary in another PR. ## What changes are included in this PR? Update docs to reflect the caveat that init cap only works on ASCII strings ## Are these changes tested? by CI ## Are there any user-facing changes? Just docs, no functional change <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
