goldmedal commented on PR #1551: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1551#issuecomment-2536645060
> Thanks, @alamb and @iffyio for reviewing. > > > In terms of the potential downstream impacts (and avoiding regressions), one thing that I suggest to help evaluate the potential downstream impact is of this trying it out in DataFusion and see if it works / passes all the tests; > > You could potentially use [apache/datafusion#13546](https://github.com/apache/datafusion/pull/13546) as a base to test with > > Sounds good 👍 I'll test this PR based on it tomorrow. Created https://github.com/apache/datafusion/pull/13734 for testing. The good news is that It only impacts a few parts of the planner and the unparser 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
