goldmedal commented on code in PR #1551:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1551#discussion_r1876251286
##########
src/ast/mod.rs:
##########
@@ -624,6 +590,12 @@ pub enum Expr {
Identifier(Ident),
/// Multi-part identifier, e.g. `table_alias.column` or `schema.table.col`
CompoundIdentifier(Vec<Ident>),
+ /// Multi-part Expression accessing. It's used to represent an access
chain from a root expression.
+ /// e.g. `expr[0]`, `expr[0][0]`, or `expr.field1.filed2[1].field3`, ...
+ CompoundExpr {
Review Comment:
> I am not sure I really like `accesses` (too many `s` 🤔 )
>
If not prefer `accesses`, how about `access_chain` or `access_path`?
> Maybe `CompoundFieldAccess` 🤔
>
`CompoundFieldAccess` is good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
