findepi commented on code in PR #13703: URL: https://github.com/apache/datafusion/pull/13703#discussion_r1879735626
########## docs/source/contributor-guide/index.md: ########## @@ -70,15 +70,39 @@ line PR. If you open a ticket and it doesn't get any response, you can try `@`-mentioning recently active community members in the ticket to get their attention. -### What Features are Good Fits for DataFusion? +### What Contributions are Good Fits? -DataFusion is designed to highly extensible, and many features can be implemented -as extensions without changing the core of DataFusion. +DataFusion is designed to be highly extensible, and many features can be +implemented as extensions without changes or additions to the core. Support for +new functions, data formats, and similar functionality can be added using those +extension APIs, and there are already many existing community supported +extensions listed in the [extensions list]. -We are [working on criteria for what features are good fits for DataFusion], and -will update this section when we have more to share. +Query engines are complex pieces of software to develop and maintain. Given our +limited maintenance bandwidth, we try to keep the DataFusion core as simple and +focused as possible, while still satisfying the [design goal] of an easy to +start initial experience. -[working on criteria for what features are good fits for datafusion]: https://github.com/apache/datafusion/issues/12357 +With that in mind, contributions that meet the following criteria are more likely +to be accepted: + +1. Bug fixes for existing features +2. Test coverage for existing features +3. Documentation improvements / examples +4. Performance improvements to existing features (with benchmarks) +5. "Small" functional improvements to existing features (if they don't change existing behavior) +6. Additional APIs for extending DataFusion's capabilities +7. CI improvements + +Contributions that will likely involve more discussion (see Discussing New +Features above) prior to acceptance include: + +1. Major new functionality (even if it is part of the "standard sql") +2. New functions, especially if they aren't part of "standard sql" Review Comment: ```suggestion 1. Major new functionality (even if it is part of the "standard SQL") 2. New functions, especially if they aren't part of "standard SQL" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
