goldmedal commented on code in PR #13695: URL: https://github.com/apache/datafusion/pull/13695#discussion_r1875168365
########## datafusion/sqllogictest/test_files/unnest.slt: ########## @@ -860,6 +860,12 @@ select count(*) from (select unnest(range(0, 100000)) id) t inner join (select u ---- 100000 +# Implicit LATERAL support +# Issue: https://github.com/apache/datafusion/issues/13659 +# TODO: https://github.com/apache/datafusion/issues/10048 +query error DataFusion error: This feature is not implemented: Physical plan does not support logical expression OuterReferenceColumn\(List\(Field \{ name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: \{\} \}\), Column \{ relation: Some\(Bare \{ table: "u" \}\), name: "column1" \}\) +select * from unnest_table u, unnest(u.column1); Review Comment: I think it's better to add a logical plan test like ``` explain select * from unnest_table u, unnest(u.column1); ``` You can refer to how other `LATERAL` tests do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
