jonahgao commented on code in PR #13674:
URL: https://github.com/apache/datafusion/pull/13674#discussion_r1872674335
##########
datafusion/expr/src/test/function_stub.rs:
##########
@@ -39,19 +39,14 @@ use crate::{
macro_rules! create_func {
($UDAF:ty, $AGGREGATE_UDF_FN:ident) => {
paste::paste! {
- /// Singleton instance of [$UDAF], ensures the UDAF is only
created once
- /// named STATIC_$(UDAF). For example `STATIC_FirstValue`
- #[allow(non_upper_case_globals)]
- static [< STATIC_ $UDAF >]:
std::sync::OnceLock<std::sync::Arc<crate::AggregateUDF>> =
- std::sync::OnceLock::new();
-
#[doc = concat!("AggregateFunction that returns a
[AggregateUDF](crate::AggregateUDF) for [`", stringify!($UDAF), "`]")]
pub fn $AGGREGATE_UDF_FN() -> std::sync::Arc<crate::AggregateUDF> {
- [< STATIC_ $UDAF >]
- .get_or_init(|| {
+ /// Singleton instance of [$UDAF], ensures the UDAF is only
created once
+ static INSTANCE:
std::sync::LazyLock<std::sync::Arc<crate::AggregateUDF>> =
Review Comment:
Narrow the scope to inside the function, so we can use a simpler name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
