jonahgao commented on code in PR #13674:
URL: https://github.com/apache/datafusion/pull/13674#discussion_r1872672241
##########
datafusion/core/tests/expr_api/mod.rs:
##########
@@ -332,13 +330,13 @@ async fn evaluate_agg_test(expr: Expr, expected_lines:
Vec<&str>) {
/// Converts the `Expr` to a `PhysicalExpr`, evaluates it against the provided
/// `RecordBatch` and compares the result to the expected result.
fn evaluate_expr_test(expr: Expr, expected_lines: Vec<&str>) {
- let batch = test_batch();
+ let batch = &TEST_BATCH;
Review Comment:
This change also avoids a clone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
