andygrove commented on code in PR #1139:
URL: https://github.com/apache/datafusion-comet/pull/1139#discussion_r1872256343
##########
native/spark-expr/src/cast.rs:
##########
@@ -723,7 +728,9 @@ fn cast_array(
timezone,
allow_incompat,
)?),
- _ if is_datafusion_spark_compatible(from_type, to_type,
allow_incompat) => {
+ _ if ugly_hack_for_poc
Review Comment:
I believe that we need to implement specific logic for adapting parquet
schemas, rather than re-using our Spark-compatible cast. There is likely some
overlap, so we can refactor the common code out. For example, regular spark
casts do not need to support unsigned integers, but we need this when adapting
Parquet schemas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
