parthchandra commented on code in PR #1139:
URL: https://github.com/apache/datafusion-comet/pull/1139#discussion_r1870366724
##########
native/spark-expr/src/utils.rs:
##########
@@ -146,6 +162,25 @@ fn timestamp_ntz_to_timestamp(
};
Ok(Arc::new(array_with_tz))
}
+ DataType::Timestamp(TimeUnit::Millisecond, None) => {
+ let array = as_primitive_array::<TimestampMillisecondType>(&array);
+ let tz: Tz = tz.parse()?;
Review Comment:
Is this called frequently (per row)? timezone parse is somewhat expensive
(and does not change for a session).
##########
native/core/src/execution/datafusion/schema_adapter.rs:
##########
@@ -161,7 +163,7 @@ impl SchemaAdapter for CometSchemaAdapter {
pub struct SchemaMapping {
/// The schema of the table. This is the expected schema after conversion
/// and it should match the schema of the query result.
- projected_table_schema: SchemaRef,
+ required_schema: SchemaRef,
Review Comment:
+1 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
