dhegberg commented on code in PR #13544: URL: https://github.com/apache/datafusion/pull/13544#discussion_r1870014671
########## datafusion/core/benches/csv_load.rs: ########## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#[macro_use] +extern crate criterion; +extern crate arrow; +extern crate datafusion; + +mod data_utils; +use crate::criterion::Criterion; +use datafusion::error::Result; +use datafusion::execution::context::SessionContext; +use datafusion::prelude::CsvReadOptions; +use datafusion::test_util::csv::TestCsvFile; +use parking_lot::Mutex; +use std::sync::Arc; +use std::time::Duration; +use test_utils::AccessLogGenerator; +use tokio::runtime::Runtime; + +fn load_csv(ctx: Arc<Mutex<SessionContext>>, path: &str, options: CsvReadOptions) { + let rt = Runtime::new().unwrap(); Review Comment: It seems that this is consistent with the other benchmarks in this package, Runtime is initialized within the bench function iterator. I can change it here though if you think it should be initialized before hand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
