davisp commented on code in PR #13632:
URL: https://github.com/apache/datafusion/pull/13632#discussion_r1869713755
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -571,10 +571,6 @@ Dml: op=[Insert Into] table=[test_decimal]
"INSERT INTO person (id, first_name, last_name) VALUES ($1, $2, $3, $4)",
"Error during planning: Placeholder $4 refers to a non existent column"
)]
-#[case::placeholder_type_unresolved(
Review Comment:
Right, this PR is intentionally about allowing the creation of
`LogicalPlan`'s with placeholders. Previously, `LogicalPlan` creation would
fail when any placeholder is part of the schema. Given that all this test is
doing is creating LogicalPlan's, this example now passes. I thought about
moving it to a new test that explicitly shows it failing at the optimization
step but then felt that that case was already covered by the other test updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
