davisp commented on code in PR #13632:
URL: https://github.com/apache/datafusion/pull/13632#discussion_r1869972881
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -357,6 +357,7 @@ impl Optimizer {
{
let start_time = Instant::now();
let options = config.options();
+ plan.validate_parameter_types()?;
Review Comment:
I thought your suggestion was a lot cleaner and have pushed e5325c3f4 to
address it. I've updated the dataframe tests, added a few to the
core/tests/sql/select.rs module, and added a `PREPARE` test to the sqllogic
test showing how things fail there as well.
Let me know if you can think of anywhere else I should add tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
