alamb commented on PR #13560: URL: https://github.com/apache/datafusion/pull/13560#issuecomment-2508967094
> By the way, @alamb, isn’t it risky to have an index_of() API in the Schema implementation? Doesn’t this create the potential for mismatches when columns are matched based solely on their names? Yes, I agree there is this danger I think the core challenge is that arrow Schema can have duplicated field names, but there are various places in DataFusion that assume the field name is unique (to resolve column referenes) Even more confusing is that the unique column name assumption is only in the `LogicalPlan` level, rather than the `ExecutonPlan` level (which uses offsets). 🤯 @findepi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
