2010YOUY01 commented on PR #13540: URL: https://github.com/apache/datafusion/pull/13540#issuecomment-2508873495
> Thank you @2010YOUY01. I reviewed the changes and LGTM. I have a few minor comments and one question: I noticed another approach of `generate_series()`, which can be used like this: `SELECT generate_series(1, 5)` I assume it is not a udtf in that context. Does this implementation leave room for that usage? Thank you for the review @berkaysynnada The answer to the question is yes, they are different function with the same name. Using same name is probably not the best idea, but we do this to keep the behavior the same as DuckDB. I added a sql test to make sure they can work together (like `select generate_series() from generate_series()`) ---- @jayzhan211 I thought about the sharing generator issue again, I think making a interface more flexible is important, so I kept the lock, and updated `RwLock` as you suggested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
