alamb opened a new issue, #1563: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1563
Part of https://github.com/apache/datafusion-sqlparser-rs/issues/1548 # Usecase We have added span information in https://github.com/apache/datafusion-sqlparser-rs/pull/1435 We would like to add span information through out the rest of the AST structures (see docs in https://github.com/apache/datafusion-sqlparser-rs/pull/1549) and list on https://github.com/apache/datafusion-sqlparser-rs/issues/1548 In order to support this feature reasonably, we need to be able to test the feature and avoid regressions # Proposal I think we need some sort of span test. I recommend 1. A new test binary like `tests/sqlparser_spans.rs` Then add a test that 1. Parses a SQL string 2. Check the spans of the AST nodes match what is expected I think we'll have to use judgement on how fine grained the location information can / should be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
