Eason0729 commented on issue #13526:
URL: https://github.com/apache/datafusion/issues/13526#issuecomment-2501013242

   > 
`https://github.com/apache/datafusion/raw/HEAD/datafusion/core/docs/source/_static/images/2x_bgwhite_original.png`
 was found in crate.io.
   > 
`https://github.com/apache/datafusion/raw/HEAD/docs/source/_static/images/2x_bgwhite_original.png`
 is the correct one.
   
   The logo is missing because `readme = "../../README.md"` in 
`datafusion/core/Cargo.toml`.
   
   If image `./static/image.png` was specified, in this case crates.io resolve 
path to `datafusion/core/static/image.png`, but `static/image.png` is what we 
would like is `static/image.png`
   
   Possible solution:
   1. use absolute path
   2. maintain a separate README.md for crate.io(create 
`datafusion/core/README.md` and `readme = "./README.md"`)
   
   I prefer first one, and I could open a PR if you agree.
   
   Also, I thinks it's an good first issue, so I can also leave it to other if 
missing logo is not an serious problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to