Omega359 commented on code in PR #13458:
URL: https://github.com/apache/datafusion/pull/13458#discussion_r1855634897


##########
datafusion/expr/src/udf.rs:
##########
@@ -477,6 +487,15 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
         true
     }
 
+    /// Returns the field metadata for this function.

Review Comment:
   I think a more detailed explanation would be useful for someone adding a new 
UDF to know why this method exists and what use case it is trying to solve. 
Without looking at this PR it's pretty opaque.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to