himadripal commented on code in PR #1086:
URL: https://github.com/apache/datafusion-comet/pull/1086#discussion_r1849060524
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -231,11 +231,9 @@ abstract class CometTestBase
df: => DataFrame): (Option[Throwable], Option[Throwable]) = {
var expected: Option[Throwable] = None
withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
- val dfSpark = Dataset.ofRows(spark, df.logicalPlan)
- expected = Try(dfSpark.collect()).failed.toOption
+ expected = Try(Dataset.ofRows(spark,
df.logicalPlan).collect()).failed.toOption
Review Comment:
if the plan parsing encounters a problem like `negative precision`, this
will catch that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
