findepi commented on code in PR #13463:
URL: https://github.com/apache/datafusion/pull/13463#discussion_r1846969267
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -859,14 +859,13 @@ impl GroupedHashAggregateStream {
)?;
}
_ => {
+ if opt_filter.is_some() {
+ return internal_err!("aggregate filter should be
applied in partial stage, there should be no filter in final stage");
Review Comment:
So nice to throw rather than silently ignore something. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
