phillipleblanc opened a new issue, #13459: URL: https://github.com/apache/datafusion/issues/13459
### Describe the bug As part of the upgrade to DataFusion v43, we found that the CrossJoin logical plan node was removed in DataFusion (https://github.com/apache/datafusion/pull/12985), replacing it with a `JOIN` with no conditions. i.e. in DataFusion the following two statements are logically similar: ```sql SELECT * FROM t1 JOIN t2; SELECT * FROM t1 CROSS JOIN t2; ``` This is not true for all databases systems, like Postgres/SQL Server - which will interpret the `JOIN` as an inner join, which then errors out that no conditions were specified: `SELECT * FROM t1 JOIN t2 -- Error: syntax error at or near "JOIN"` For the unparser, we should return an explicit CROSS JOIN when we unparser a JOIN with no conditions. ### To Reproduce Run the unparser for the following query: `SELECT * FROM t1 CROSS JOIN t2` and observe it gets unparsed to `SELECT * FROM t1 JOIN t2` ### Expected behavior `SELECT * FROM t1 CROSS JOIN t2` and `SELECT * FROM t1 JOIN t2` are unparsed to `SELECT * FROM t1 CROSS JOIN t2` ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
