alamb commented on code in PR #13422:
URL: https://github.com/apache/datafusion/pull/13422#discussion_r1844328460
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -1146,6 +1146,33 @@ fn test_join_with_table_scan_filters() -> Result<()> {
assert_eq!(sql.to_string(), expected_sql);
+ let right_plan_with_filter_schema = table_scan_with_filters(
Review Comment:
The instructions for doing so are in
https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/string/README.md
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -1146,6 +1146,33 @@ fn test_join_with_table_scan_filters() -> Result<()> {
assert_eq!(sql.to_string(), expected_sql);
+ let right_plan_with_filter_schema = table_scan_with_filters(
Review Comment:
These are tests for the SQL unparsing
Is there any chance you could add an EXPLAIN test in .slt instead?
Perhaps somewhere in datafusion/sqllogictest/test_files/push_down_filter.slt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
