peasee opened a new pull request, #13405:
URL: https://github.com/apache/datafusion/pull/13405
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #13027
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This change ensures that table references which don't exist at their current
level are removed. For example, `SELECT ta.j1_id FROM (SELECT j1_id FROM j1
ta)` is invalid because the subquery is un-aliased so `ta` is not a valid
reference at the top-level projection.
This is usually caused by derived subqueries, both un-aliased and aliased.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
* For each `select_to_sql_expr`, collects the available table identifiers at
that level from the projection and table joins.
* Iterates over the projection and order by and compares them to the list of
collected identifiers. For identifiers that are not found, strips their table
reference leaving just the bare column (e.g. `ta.j1_id` -> `j1_id`).
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes. A collection of new plan-to-SQL roundtrip tests to validate the changes.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
