findepi commented on code in PR #13345:
URL: https://github.com/apache/datafusion/pull/13345#discussion_r1835746256
##########
datafusion/functions/src/datetime/date_bin.rs:
##########
@@ -491,150 +491,197 @@ mod tests {
use chrono::TimeDelta;
#[test]
- #[allow(deprecated)] // TODO migrate UDF invoke to invoke_batch
fn test_date_bin() {
- let res = DateBinFunc::new().invoke(&[
-
ColumnarValue::Scalar(ScalarValue::IntervalDayTime(Some(IntervalDayTime {
- days: 0,
- milliseconds: 1,
- }))),
- ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1),
None)),
- ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1),
None)),
- ]);
+ let res = DateBinFunc::new().invoke_batch(
+ &[
+ ColumnarValue::Scalar(ScalarValue::IntervalDayTime(Some(
+ IntervalDayTime {
+ days: 0,
+ milliseconds: 1,
+ },
+ ))),
+
ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)),
+
ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)),
+ ],
+ 0,
Review Comment:
would 1 be more suitable?
(same in other places)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
