findepi commented on issue #13261: URL: https://github.com/apache/datafusion/issues/13261#issuecomment-2460923423
The positions (numbers) themselves are not enough. We need to return file paths as well. The deletions will go back into TableProvider, right? so the TableProvider itself could determine what's the data it needs to execute deletions. I think looking at how Trino used to implement deletes could be enlightening. It starts here: https://github.com/trinodb/trino/blob/400/core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java#L618 by asking data source what is the data needed for deletion tracking. I wrote "used to" because current implementation is all MERGE-based and the code is much harder to follow, and thus less inspiring :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
