alamb commented on code in PR #13182:
URL: https://github.com/apache/datafusion/pull/13182#discussion_r1830892955
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1217,25 +1217,24 @@ impl LogicalPlanBuilder {
let join_key_pairs = equi_exprs
.0
.into_iter()
- .zip(equi_exprs.1.into_iter())
+ .zip(equi_exprs.1)
.map(|(l, r)| {
let left_key = l.into();
let right_key = r.into();
-
- let mut left_using_columns = HashSet::new();
+ let mut left_using_columns = HashSet::new();
expr_to_columns(&left_key, &mut left_using_columns)?;
let normalized_left_key =
normalize_col_with_schemas_and_ambiguity_check(
left_key,
- &[&[self.plan.schema(), right.schema()]],
- &[left_using_columns],
+ &[&[self.plan.schema()]],
Review Comment:
I see -- the idea here is that the left keys can only refer to columns from
the left input. That makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
