austin362667 commented on code in PR #13221:
URL: https://github.com/apache/datafusion/pull/13221#discussion_r1826463727


##########
datafusion/sqllogictest/test_files/string/string_query.slt.part:
##########
@@ -1096,3 +1096,20 @@ Rapha Raphael NULL datafusionДатаФус 
datafusionДатаФусион NULL
 und under_score NULL un iść core un iść core NULL
 p percent NULL pan Tadeusz ma iść w kąt pan Tadeusz ma iść w kąt NULL
 NULL NULL NULL NULL NULL NULL
+
+# TODO: Support Utf8View for bit_length array string function

Review Comment:
   Thanks @alamb 
   As I understand it, applying `bit_length()` to a column will currently fail 
because `arrow::compute::kernels::length::bit_length` does not yet support 
UTF-8 views (depends on [PR](https://github.com/apache/arrow-rs/pull/6671) in 
`arrow-rs`). However, it's still used in the following code path:
   
https://github.com/apache/datafusion/blob/a16854837a826ad60d9e254b75b6135a076f6545/datafusion/functions/src/string/bit_length.rs#L74



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to