alamb commented on code in PR #13217:
URL: https://github.com/apache/datafusion/pull/13217#discussion_r1826305081
##########
datafusion/expr/src/expr.rs:
##########
@@ -1554,13 +1554,13 @@ impl Expr {
/// Returns true if there are any column references in this Expr
pub fn any_column_refs(&self) -> bool {
self.exists(|expr| Ok(matches!(expr, Expr::Column(_))))
- .unwrap()
+ .expect("exists closure is infallible")
Review Comment:
I suppose we could rename `exists` to `try_exists` and then switch `exists`
to not be fallable 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
