lovasoa commented on code in PR #1490:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1490#discussion_r1825284497
##########
tests/sqlparser_mssql.rs:
##########
@@ -570,6 +570,41 @@ fn parse_substring_in_select() {
}
}
+#[test]
+fn parse_mssql_execute_stored_procedure() {
Review Comment:
It is mssql specific. But I'd still prefer not gating the behavior, if that
works for you.
In general, when a particular dialect's syntax is not incompatible with
other dialects, I think it's better to always accept parsing it. Library users
are always free to reject successfully parsed ASTs later, but when something
fails to parse, you have fewer options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
