alamb commented on code in PR #13128:
URL: https://github.com/apache/datafusion/pull/13128#discussion_r1825266578
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -3980,4 +3994,69 @@ mod tests {
unimplemented!("not needed for tests")
}
}
+ #[derive(Debug)]
+ struct VolatileUdf {
+ signature: Signature,
+ }
+
+ impl VolatileUdf {
+ pub fn new() -> Self {
+ Self {
+ signature: Signature::exact(vec![], Volatility::Volatile),
+ }
+ }
+ }
+ impl ScalarUDFImpl for VolatileUdf {
+ fn as_any(&self) -> &dyn std::any::Any {
+ self
+ }
+
+ fn name(&self) -> &str {
+ "VolatileUdf"
+ }
+
+ fn signature(&self) -> &Signature {
+ &self.signature
+ }
+
+ fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
+ Ok(DataType::Int16)
+ }
+ }
+ #[test]
+ fn test_optimize_volatile_conditions() {
+ let fun = Arc::new(ScalarUDF::new_from_impl(VolatileUdf::new()));
+ let rand = Expr::ScalarFunction(ScalarFunction::new_udf(fun, vec![]));
+ {
+ let expr = rand
+ .clone()
+ .eq(lit(0))
+ .or(col("column1").eq(lit(2)).and(rand.clone().eq(lit(0))));
+
+ assert_eq!(simplify(expr.clone()), expr);
+ }
+
+ {
+ let expr = col("column1")
+ .eq(lit(2))
+ .or(col("column1").eq(lit(2)).and(rand.clone().eq(lit(0))));
+
+ assert_eq!(simplify(expr), col("column1").eq(lit(2)));
Review Comment:
It would seem to me this should still be the same thing -- namely that we
shouldn't remove the `rand() = 0` condition 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
