yoavcloud commented on code in PR #1487:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1487#discussion_r1824431849
##########
tests/sqlparser_hive.rs:
##########
@@ -534,6 +534,20 @@ fn parse_use() {
);
}
+#[test]
Review Comment:
I understand the preference now is for the parser to err on the side of
accepting queries even if the dialect doesn't actually support them right? If
so, then yes, we can move the tests to common. The SHOW syntax is somewhat
popular but it's not a standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
