iffyio commented on code in PR #1487:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1487#discussion_r1824592282
##########
tests/sqlparser_hive.rs:
##########
@@ -534,6 +534,20 @@ fn parse_use() {
);
}
+#[test]
Review Comment:
Yeah we have a few scenarios where the parser accepts input that isn't
supported by the dialect. I figured here it could be easier to do so just as
well, the alternative would be to add explicit methods to the dialect trait i.e
`dialect.supports_show_databases()` `dialect.supports_show_schemas()` etc which
I think would also be fine if that's preferrable from an impl pov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
