grigoryan-sergey commented on PR #1482: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1482#issuecomment-2445897273
Hi @iffyio. What do you mean by both styles? Camel case as in Clickhouse and uppercase notations? Currently in the code both of this styles are kind of mixed. I agree with you, it would be best to support both styles. In this PR I suggested to change only those which affect Clickhouse SQL generation. Basically the styles were mixed before and are also mixed after the PR :). The problem with supporting two styles, is the complication. We need to introduce dialects not for just parsing but also for generating the SQL string. I am not that good at the knowledge of the codebase, so I cannot tell will it be complicated or not to implement. But my current proposal fixes the problem for the database which has case sensitive types (Clickhouse) and does not brake compatability (cases were mixed before and also after). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
