Michael-J-Ward opened a new issue, #13168:
URL: https://github.com/apache/datafusion/issues/13168

   ### Is your feature request related to a problem or challenge?
   
   https://github.com/apache/datafusion/pull/12857  added the `expressions` 
method to the `WindowUDFImpl` trait.
   
   The default impl currently only takes the first `input_expr` and discards 
the rest.
   
   
https://github.com/apache/datafusion/blob/444a673682a4823b98695568ecdab1087b5b6a60/datafusion/expr/src/udwf.rs#L314-L319
   
   This altered behavior caused a regression in a two column Window UDF used in 
`datafusion-python` tests. See [this comment detailing the 
error](https://github.com/apache/datafusion-python/pull/905#issuecomment-2442642237)
 and this commit that [fixes 
it](https://github.com/apache/datafusion-python/pull/905/commits/3676b1d0c8bcb861b9c4cf00dc15206dd4bec713).
   
   ### Describe the solution you'd like
   
   The default behavior should just return all the input expressions.
   
   ### Describe alternatives you've considered
   
   I didn't find any justification for only taking the first `input_expr` as 
the default behavior, so probably I'm missing something.
   
   @jcsherin - please let me know if there's a reason that I'm missing for this 
behavior. 
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to