Blizzara commented on code in PR #12112:
URL: https://github.com/apache/datafusion/pull/12112#discussion_r1819756919
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1831,8 +1832,13 @@ fn from_substrait_type(
Ok(DataType::Interval(IntervalUnit::YearMonth))
}
r#type::Kind::IntervalDay(_) =>
Ok(DataType::Interval(IntervalUnit::DayTime)),
Review Comment:
Yup see
https://github.com/apache/datafusion/pull/12112#discussion_r1818961187. I think
we should change it, maybe with some option so that user can decide if they
want to throw or accept the precision loss. But will be a separate PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
